Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491240 --- Comment #12 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-03-23 23:46:02 EDT --- Review: + package builds in mock (rawhide i586). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1255875 + rpmlint output for SRPM and for RPM. dropwatch.i586: E: explicit-lib-dependency libnl ==> Can be ignored + source files match upstream url 34338735d1d2d339c92f21d9c7f1202f dropwatch-1.0.tbz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI App. Can you also tell me how to test dropwatch and can it be possible to test on F10? on F10 when I ran dropwatch I got Unable to find NET_DM family, dropwatch can't work Cleaning up on socket creation error -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review