Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225978 --- Comment #5 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-03-23 16:37:22 EDT --- (In reply to comment #4) > It's translated as part of the specspo package. Okay, then it has to wait until F11 is released. You can add a comment to the spec file about the need to fix the summaries, however! Review for 1.2.86-1 as follows: rpmlint output: kudzu.src: W: summary-ended-with-dot The Red Hat Linux hardware probing tool. kudzu.x86_64: W: summary-ended-with-dot The Red Hat Linux hardware probing tool. kudzu-devel.x86_64: W: summary-ended-with-dot Development files needed for hardware probing using kudzu. 4 packages and 0 specfiles checked; 0 errors, 3 warnings. - Is it really necessary to have the documentation in the devel package too? I'd prune these. Review: ? source files match upstream (no srpm provided) X package meets naming and versioning guidelines. X specfile is properly named, is cleanly written and uses macros consistently. - dist tag is present. MUST: Add this. X build root is correct. X license field matches the actual license. X license is open source-compatible. X license text included in package. X latest version is being packaged. X BuildRequires are proper. * Please clean the conflicts, requires and buildrequires. ideally they should be given one per line in alphabetical order X compiler flags are appropriate. X %clean is present. X package builds in mock. X package installs properly. X debuginfo package looks complete. ? rpmlint is silent. * The summaries still need fixing. X final provides and requires are sane X no check available X no shared libraries are added to the regular linker search paths. X owns the directories it creates. X doesn't own any directories it shouldn't. X no duplicates in %files. X file permissions are appropriate. X no scriptlets present. X code, not content. X documentation is small, so no -docs subpackage is necessary. X %docs are not necessary for the proper functioning of the package. X headers are in devel package - static libraries are in static package * The devel package needs to Provides: kudzu-static=%{version}-%{release} X no pkgconfig files. X no libtool .la droppings. X no desktop files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review