Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491694 Itamar Reis Peixoto <itamar@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |itamar@xxxxxxxxxxxxxxxx --- Comment #1 from Itamar Reis Peixoto <itamar@xxxxxxxxxxxxxxxx> 2009-03-23 12:57:35 EDT --- 1 - replace test "x$RPM_BUILD_ROOT" != "x" && rm -rf $RPM_BUILD_ROOT mkdir %{buildroot} with rm -rf $RPM_BUILD_ROOT 2 - look about source0 https://fedoraproject.org/wiki/Packaging/SourceURL 3 - missing dist-tag Release: 1%{?dist} 4 - you can make install section smaller, merging commands, there are no need of install -d if install -Dp create directory's -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review