Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490028 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-03-23 11:44:05 EDT --- Some notes: * %define -> %global - Now Fedora suggests to use %global instead of %define, especially for the nested macro definition. ref: https://fedoraproject.org/wiki/Packaging/Python#System_Architecture https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define (The latter one says "Draft", however it is already accepted by FESCo). * Naming - Fedora prefers to use the tarball name as rpm name as much as possible. For this package I recommend to use "pytc" as rpm name. * Requires ---------------------------------------------------------- Requires: python >= 2.3 Requires: tokyocabinet ---------------------------------------------------------- - Both of these are unnecessary. These dependencies are automatically pulled in by libraries' dependencies caught by rpmbuild itself. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review