Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226376 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Flag|fedora-review? |fedora-review+ --- Comment #3 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-03-23 10:20:08 EDT --- Review: X source files match upstream (we are upstream) X package meets naming and versioning guidelines. X specfile is properly named, is cleanly written and uses macros consistently. X dist tag is present. X build root is correct. X license field matches the actual license. X license is open source-compatible. X license text not included upstream. X latest version is being packaged. X BuildRequires are proper. X compiler flags are appropriate. X %clean is present. X package builds in mock. X package installs properly. X debuginfo package looks complete. X rpmlint is silent. ? final provides and requires are sane: * Is ncurses really necessary?? X no check available X no shared libraries are added to the regular linker search paths. X owns the directories it creates. X doesn't own any directories it shouldn't. X no duplicates in %files. X file permissions are appropriate. X no scriptlets present. X code, not content. X documentation is small, so no -docs subpackage is necessary. X %docs are not necessary for the proper functioning of the package. X no headers. X no pkgconfig files. X no libtool .la droppings. X no desktop files I don't think the ncurses requirement should be there, since the bug only affects older distributions. Maybe add a conditional for older distros that are affected by the bug? On the other hand, this would make the spec unnecessarily complicated. In any case, add a note about the ncurses requirement so that it may be dropped in the future. **** The package has been found to adhere to the guidelines and is thus APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review