Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491519 --- Comment #5 from Conrad Meyer <konrad@xxxxxxxxxx> 2009-03-22 19:35:30 EDT --- Requires: openttd seems wrong (because openttd requires this for graphics). I think maybe a solution is for this to go in %{_datadir}/%{name}/ and when openttd is installed and requires this, it can symlink %{_datadir}/openttd/data to this package (if it's too hard to change where openttd looks). This is one argument for including opengfx in openttd (opengfx can be installed into the correct place without a hack, and the two-way requires can be avoided). The use of __<command> macros is unnecessary (%{__rm}, %{__mv}, etc). Fedora is not Mandriva. This bit concerns me (slightly): # These are already in %doc %{__rm} $RPM_BUILD_ROOT%{_datadir}/openttd/data/COPYING %{__rm} $RPM_BUILD_ROOT%{_datadir}/openttd/data/readme.txt Are these really never used by OpenTTD? If so it's fine. Otherwise this looks pretty clean (fairly uncomplicated data-only package). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review