Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490724 --- Comment #2 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> 2009-03-20 17:15:06 EDT --- (In reply to comment #1) > Created an attachment (id=336118) --> (https://bugzilla.redhat.com/attachment.cgi?id=336118) [details] > [Review] > > Attached is my initial review. > > In summary: > - Fix the UTF-8 and one-line-command-in-%post(un) rpmlint warnings. I would rather not because if I do so the pdf generated is corrupted. In addition please see : https://www.redhat.com/archives/fedora-devel-list/2009-January/msg00741.html Regarding the one-line-command-in-%post(un) see: http://fedoraproject.org/wiki/Packaging/R > - Fix the License (GPLv2+) This actually needs information from upstream since the license version are different in the DESCRIPTION file, the website and the sources. > - Fix the duplicate files Fixed > - Why is %{_bindir}/R used in %check? Fixed (change R CMD INSTALL to %{_bindir}R CMD INSTALL) > Also, you may want to use %{version} in > your Source0. But that's discretionary. Fixed I will upload the new version as soon as I have news from upstream concerning the license used. Thanks for the review -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review