Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491201 --- Comment #2 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-03-20 11:26:29 EDT --- rpmlint output: ninvaders.x86_64: W: file-not-utf8 /usr/share/doc/ninvaders-0.1.1/ChangeLog 3 packages and 0 specfiles checked; 0 errors, 1 warnings. - Fix the rpmlint warning with iconv -f iso-8859-1 -t utf8 ChangeLog > ChangeLog.new && \ touch -r ChangeLog ChangeLog.new && mv ChangeLog.new ChangeLog - Change buildroot to the Guideline's recommended version %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) - Remove Requires: ncurses as this is automatically picked up by rpmbuild. - Add trailing period to %description - Enable smp make with make %{?_smp_mflags} - Is there a reason why you change the name of the binary? I think you should keep it consistent with upstream... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review