Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465858 --- Comment #6 from Lubomir Rintel <lkundrak@xxxxx> 2009-03-19 17:55:14 EDT --- Thanks for the review, Stepan. (In reply to comment #5) > FAIL Summary for %package -n fuse-afs is wrong Fixed. > FAIL no duplicates in %files. > #fedora-devel 17:11 < tibbs|h> You can include COPYING exactly once. > Do not duplicate doc files, remove %doc lines from subpackages. I removed it from -devel since it drags in the main package, but did not remove it from the fuse driver. Documentation files are here on purpose, and I don't see why shouldn't they be duplicated (coincidentally, I asked on #fedora-devel too, and got a response COPYING should be in each subpackage). Do you strongly object this? > FAIL Please use %configure --disable-static and drop %exclude *.a Done, thanks for noticing. SPECS: http://v3.sk/~lkundrak/SPECS/afpfs-ng.spec SRPMS: http://v3.sk/~lkundrak/SRPMS/afpfs-ng-0.8.1-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review