Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459925 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |oget.fedora@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |oget.fedora@xxxxxxxxx Flag| |fedora-review? --- Comment #2 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-03-18 13:42:54 EDT --- I reviewed this package. Here are my notes: * static libraries are usually not desired in Fedora. But in this case, upstream only provides a static library and hence we can go with their choice. But then the devel package should have Provides: %{name}-static = %{version}-%{release} and whenever a package BR's this one, it should BR libowfat-static instead of libowfat-devel * Requires: dietlibc-devel (the top one) is not required. * This package installs files in /usr/lib64/dietlibc/include/libowfat/ but the dietlibc-devel package has its files installed in /usr/lib/dietlibc/include/ regardless of the architecture. So you need to replace the occurences of %{_libdir} with %{_prefix}/lib in the SPEC file. - The source files don't have a license in their headers, but the README file explicitly says: libowfat is a library of general purpose APIs extracted from Dan Bernstein's software, reimplemented and covered by the GNU General Public License Version 2 (no later versions). so license as GPLv2 is okay. * We prefer %defattr(-,root,root,-) * Please use %{name}.a instead of libowfat.a in the %files section for macro consistency. * Fedora specific compilation flags are not honored. Please fix this. * Parallel make must be supported whenever possible. If it is not supported, this should be noted in the SPEC file as a comment. ? Is there any program which we can use to see libowfat in action? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review