Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480235 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2009-03-18 09:09:04 EDT --- Looking at http://tuxbrewr.fedorapeople.org/subtitlecomposer I don't see any scriptlets. But I don't see any remaining problems or blockers, APPROVED. Cosmetic items worth fixing before building: 1. icon scriptlets (see comment #3 for an example). 2. use kde4 macros like %{_kde4_iconsdir} instead of %{_datadir}/icons %{_kde4_appsdir} instead of %{_datadir}/kde4/apps 3. drop "for KDE" in summary/description. It should work just fine outside of KDE. 4. Not sure if it's possible, but try to use a full URL for Source0. kde-apps may make this difficult to do though. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review