Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480279 --- Comment #18 from Feng Yu <rainwoodman@xxxxxxxxx> 2009-03-17 20:57:50 EDT --- Thanks for reviewing. > > Issues: > - License is unclear: Spec says GPLv2+ while package includes GPLv3 as COPYING. > Aditionaly the tarball includes two files GPLv2 and GPLv3. If a package has > parts that are licensed under different licenses we usually list them all in > the spec ("GPLv2 and GPLv3"). If you summarize this as "GPLv2+", you should > include the GPLv2+ in the package and you need to be aware of the fact that it > also means means "any later version", including GPLv4. It is a GPLv2. The GPLv3 file is not used for licensing. The COPYING file contains wrong content. > > - Download the sources again to make sure they really match. Also take care of > the timestamps, see > https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps > > - Docs are incomplete: Include Authors and the correct license(s), but do not > include ChangeLog and NEWS as long as they are empty What about adding links to the real ChangeLog and NEWS on the web in these empty files? > > - Docs are installed in the wrong dir: > %{_datadir}/doc/%{name}/ instead of > %{_datadir}/doc/%{name}-version/ > Just remove %{_datadir}/doc/%{name}/ completely during %install and let let rpm > take care of installing the docs: > ... > rm -f $RPM_BUILD_ROOT/%{_libdir}/libgnomenu.la > rm -rf $RPM_BUILD_ROOT/%{_datadir}/doc/%{name}-version/ > ... > %files -f %{name}.lang > %defattr(-,root,root,-) > %doc AUTHORS COPYING GPLv2 GPLv3 README > > This also fixes the unowned dir mentioned above > > - remove the "# comment" leftover > > - What exactly do you want to achieve with the "%if 0%{?rhel5}" statements? Do > you want to build the xfce4-panel plugin only on Fedora and RHEL4? > Only on Fedora. the xfce4-panel plugin can't build on RHEL5, because the dependency are not satisfied. > - Does the xfce4-panel plugin work for you? For me it does nothing (I'm already > on Xfce 4.6, but the panel api has not changed from 4.4) There are post installation configuration steps. You have to export GTK_MODULES=globalmenu-gnome. Where should this be mentioned? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review