Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490318 --- Comment #4 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-03-17 20:02:02 EDT --- (In reply to comment #3) Thanks a lot for the review! > > * License: TODO > - actual license matches License field > - probably "Public Domain" could be added to the License field, too > - License field packaged > added > * build requirements: TODO > - probably dbus-python and gettext can be ommited (builds fine without these > tools) > dbus-python removed (it is being pulled up by PyKDE4). rawhide build fails without gettext, so I kept that one. > > * .desktop file: TODO > - desktop file exists > - however, there is no entry in the menu when running gnome; I would suggest > adding the gnome category > I added the AudioVideo category. It should go to the Multimedia group now. updated files: Spec URL: http://oget.fedorapeople.org/review/frescobaldi.spec SRPM URL: http://oget.fedorapeople.org/review/frescobaldi-0.7.7-2.fc10.src.rpm Changelog: 0.7.7-2 - Remove BuildRequires: dbus-python - Fix the year of the previous changelog entry - Add "Public Domain" to the license tag - Add AudioVideo category to the .desktop file - Add disttag -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review