Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470066 Pierre-YvesChibon <pingou@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #10 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> 2009-03-17 15:00:22 EDT --- Here is the review: * You should change your %prefer to %global see : https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define (although it mentions draft it has been accepted). X can't check upstream source. * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. -> Although I am wondering if we should not used the same than the one provided in R while doing "library()" ie: Tools for analyzing QTL experiments * description is OK. -> You might though develop it a bit more by taking some descriptive sentence in http://www.rqtl.org/ * dist tag is present. * build root is OK. * license text included in package. -> the LICENSE file and some headers have been corrected in the git repo to GPLv2+ * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in koji (rawhide). -> http://koji.fedoraproject.org/koji/taskinfo?taskID=1246648 * package installs properly. * debuginfo package looks complete. * rpmlint is silent (barring the two expected R complaints) * final provides and requires are sane * %check is present and all tests pass. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (R package registration). * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. I let you change %global to %define and the description and summary (if you feel like) before commiting to the cvs (but please do change %define). ------------------------------------------------------------------------ -- R-qtl is approved by Pierre-Yves Chibon ~pingou ------------------------------------------------------------------------ Thanks for bringing a new R package into Fedora and you might be interested by http://rpms.famillecollet.com/rpmphp and http://rpms.famillecollet.com/rpmphp/rpm.php?type=R -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review