Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489751 --- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2009-03-17 05:43:21 EDT --- Notes: > %patch0 -p1 Add postfix. E.g. you should invoke %patch in the following way: %patch0 -p1 -b .some_descriptive_postfix > dos2unix -k *.txt ChangeLog *.url LICENSE EXCEPTION Consider using sed -i 's|\r||g' instead (just to avoid dos2unix as a BR). > iconv -f latin1 -t utf-8 EXCEPTION > EXCEPTION.new touch -r EXCEPTION EXCEPTION.new mv -f EXCEPTION.new EXCEPTION This piece of spec (and similar ones) is not fail-safe. You should change it to something like this: iconv -f latin1 -t utf-8 EXCEPTION > EXCEPTION.new && touch -r EXCEPTION EXCEPTION.new && mv -f EXCEPTION.new EXCEPTION Also, you should use some bash syntax sugar: "mv -f EXCEPTION.new EXCEPTION" == "mv -f EXCEPTION{.new,}" "touch -r EXCEPTION EXCEPTION.new" == "touch -r EXCEPTION{,.new}" > %files ... %{_libdir}/*.so This is not a blocker, actually, but I believe, that dlopened objects should be in a proper subdir in %_libdir (for example %{_libdir}/%{name} ). However, there are many exceptions (unixODBC, tcl/tk among them), who stores their *so-libraries in %_libdir. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review