Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jfbterm - Japanese Console for Linux Frame Buffer Device https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201170 ------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx 2006-08-20 06:29 EST ------- Builds fine normally and rpmlint is clean. I am a tad concerned with this snippet though and have asked for advice on it. There may be both a security and SELinux implication with it. 8--> %{__cat} > 60-jfbterm.perms <<EOF # permission definitions <console> 0660 /dev/tty0 0660 root <console> 0600 /dev/console 0600 root EOF %{__mkdir_p} -m 755 %{buildroot}%{_sysconfdir}/security/console.perms.d %{__install} -m 644 60-jfbterm.perms \ %{buildroot}%{_sysconfdir}/security/console.perms.d/ <--8 As for the spec file... Good Follows FE dist tags No duplicates in the BRs In american english and with correct permissions No ownership conflicts Includes docs Set out logically It looks good. Unsure Are you installing fonts to %{_datadir}/fonts/%{name}? if you are, you'll need to do what you did with fonts package this relies on with mkfontdir Very unsure Security implications (detailed above) Builds cleanly in mock -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review