Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #32 from Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> 2009-03-16 16:28:48 EDT --- Build failed on F-10 http://koji.fedoraproject.org/koji/getfile?taskID=1244213&name=build.log But worked on F-11 (so probably that was expected). http://koji.fedoraproject.org/koji/taskinfo?taskID=1244393 This package doesn't use our CFLAGS: - some part uses -O3 - other parts uses ... -fPIC -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-long-long -pedantic -fno-strict-aliasing -fshort-wchar -pthread -pipe -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions Instead, the package have to obbey to the $RPM_OPT_FLAGS macro. Once that said, according to thunderbird 3: http://kojipkgs.fedoraproject.org/packages/thunderbird/3.0/1.beta2.fc11/data/logs/i586/build.log the -O2 compiler optimization doesn't seems compatible with xulrunner and thunderbird have it changed to -Os. This is the same with stable release. So we may need to do the same. Actually only ppc64 use our CFLAGS since it is tweaked from the spec for minimal toc, but it is added twice since this is now in the default RPM_OPT_FLAGS for ppc64 by F-11 See in http://koji.fedoraproject.org/koji/getfile?taskID=1244397&name=build.log - Internal taglib - I've thought works was done to have it use the system version. Why is it still internally used by F-11 ? - Weird conditionals %ifnarch i586 and %ifarch i586 better to use: %ifarch %{ix86} %define sb_arch i686 %else %define sb_arch %{_arch} %endif That will make the spec to work on F-10 and F-11. - It seems to be better to have "sed -i s/-gstabs+//g configure.ac " for all arches unless there are good reason to override -g from our RPM_OPT_FLAGS. - Icons sizes: "cp -p ../app/branding/icon64.png " etc Only the 64 pixels is available upstream. It could be nicer to use the .xpm icon pixelated to png with differents size, or to use the .xpm icon directly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review