Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487791 Steven M. Parrish <smparrish@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smparrish@xxxxxxxxxxxxxxxx --- Comment #5 from Steven M. Parrish <smparrish@xxxxxxxxxxxxxxxx> 2009-03-16 14:36:03 EDT --- A few quick notes in the %install and %clean sections replace rm -rf %{buildroot} with rm -rf $RPM_BUILD_ROOT as it is the more prefered way of doing things also make install DESTDIR=%{buildroot} -C %{_target_platform} should be make install DESTDIR=${RPM_BUILD_ROOT} -C %{_target_platform} and desktop-file-install --vendor "" \ --dir %{buildroot}%{_datadir}/applications/kde4 \ --remove-key=Path \ %{buildroot}%{_datadir}/applications/kde4/%{name}.desktop should be desktop-file-install --vendor "" \ --dir $RPM_BUILD_ROOT%{_datadir}/applications/kde4 \ --remove-key=Path \ $RPM_BUILD_ROOT%{_datadir}/applications/kde4/%{name}.desktop This just helps keep all packages consistent Steven -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review