Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487737 --- Comment #9 from Alexey Torkhov <atorkhov@xxxxxxxxx> 2009-03-16 04:22:16 EDT --- Created an attachment (id=335317) --> (https://bugzilla.redhat.com/attachment.cgi?id=335317) Patch for makefile to use rpm optflags (In reply to comment #8) > Light WMs like openbox and dwm (slock was written for) bound commands, > not fd.o .desktop nonsense. Ok then. Please add a comment to spec telling that it is not need .desktop file and brief explanation. > How to create static patch for config.mk that will get arch-specific CFLAGS? Very simple - use $RPM_OPT_FLAGS environment variable. I've made a patch - it is in attachment as an example. Programs with good makefiles do not require any patching at all - you can pass flags in make call just like "make CXXFLAGS=...", but this makefile written in bad way, so it'll not add includes to flags. > I think sed expressions are pretty good options for one-line patching - my > EFL/E17 specs have plenty of those. This is a bad practice in case of makefiles - you won't notice when upstream source changes. I think, sed is good in opposite cases - when patch would be ugly, or big, or when change made by sed if safe for changes, etc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review