Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487737 Alexey Torkhov <atorkhov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |atorkhov@xxxxxxxxx Flag| |fedora-review? --- Comment #5 from Alexey Torkhov <atorkhov@xxxxxxxxx> 2009-03-15 17:08:39 EDT --- - Replace two seds with a patch. It will be easier to read. Moreover, if upstream decide to change flags in makefile in future, sed will silently continue with old values and patch will fail. - This is a GUI application, you should create .desktop file for it. See https://fedoraproject.org/wiki/Packaging/Guidelines#desktop -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review