Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478771 Alexey Torkhov <atorkhov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|ianweller@xxxxxxxxx |atorkhov@xxxxxxxxx Flag|fedora-review? |fedora-review+ --- Comment #5 from Alexey Torkhov <atorkhov@xxxxxxxxx> 2009-03-15 15:03:38 EDT --- Here goes the review: + rpmlint output without errors spring-maps-default.noarch: W: no-documentation spring-maps-default.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Empty build section could be added. + The package named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license. + Source package does not includes the text of the license(s) in its own file. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package matches the upstream source. + The package successfully compiles and builds into binary rpms on at least one primary architecture. + If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Bugs should be filled against all 4 spring packages after their acceptance and added to FE-ExcludeArch-ppc{,64} tracker: https://fedoraproject.org/wiki/Packaging/Guidelines#Architecture_Build_Failures + All build dependencies are listed in BuildRequires. + No need to deal with locales. + The package does not designed to be relocatable. + A package owns all directories that it creates. + A package does not list a file more than once in %files listings. + Permissions on files are set properly. + Package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT. + Package consistently uses macros. + Does not have documentation. + Package does not own files or directories already owned by other packages. + At the beginning of %install, package runs rm -rf $RPM_BUILD_ROOT. + All filenames in rpm packages are valid UTF-8. While this package is APPROVED, cvs creation should be delayed until all four spring packages are accepted. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review