Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486584 Xavier Lamien <lxtnow@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Xavier Lamien <lxtnow@xxxxxxxxx> 2009-03-15 07:24:14 EDT --- Merging additional review block from comment #1 OK source files match upstream(double checked): 778ecbaf87bc3fe56df210841a80aa83eb64b78a26c4bd0079143705a1301be9 CGI-Application-4.21.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK License text included in package. OK latest version is being packaged (not mandatory). OK BuildRequires are proper and match PERL packaging Guideline. OK Build framework is used and correctly BR'ed. OK %clean is present. OK package builds in koji (Rawhide, f-10). OK rpmlint is silent. OK final provides and requires look good. OK %check is present and all tests pass. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK documentation is small, so no -docs subpackage is necessary. That package is good for FPC. *APPROVED* Please, follow those steps below before request CVS branch and sponsorship. Sponsorship: https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group Once you get approved as a Fedora packager go to: https://fedoraproject.org/wiki/CVS_admin_requests I'd also like that you start review a couple of packages Review Requests to track down your skills and your understanding in Fedora rpm packaging's way. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review