Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453849 --- Comment #4 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> 2009-03-15 02:39:52 EDT --- (In reply to comment #3) > I've just done a full review, basicly the same issues as with globus-core: > > MUST FIX > -------- > * Add s390x as 64 bit arch > * Since this is for devel use only, drop the -devel subpackage and > put all %files in main package > * Document Source# origin > > I guess the same goes for a lot of the other globus-packages it would be good > if you could do an update of those too. Your 1st and 3rd point are trival (and I had already fixed them in my private copy after your comments to globus-core but not uploaded a new version yet). The 2nd point I think is a misunderstanding. The main subpackage is not a devel package. It is there to satisfy a runtime dependency, not a build dependency. The globus-libtool and globus-openssl packages are what I call GPT glue packages. They provide the GPT metadata files for packages already in the distribution (libtool-ltdt and openssl), so that the packages in the distribution can be used instead of duplicating them - which would violate the packaging guidelines. As the packages they replace they have a main and a devel subpackage (globus-openssl even has a utils subpackage to split off the dependency on the openssl binaries from the openssl libraries - which the GPT package does but Fedora package does not do). If someone installs the binary globus packages and the grid-packaging-tools package and uses gpt to examine the installed packages the user will get a complaint about missing packages if the GPT metadata from the main package is missing, but this user has no need for neither the GPT metadata from the devel subpackage nor of the dependencies it drags in. Also, all the RPM package dependencies in the specfiles for the globus packages are autogenerated from the GPT source package metadata. Packages that require the libltdl runtime libraries will therefore depend on globus-libtool rather than libltdl directly and get the libltdl library dependency from the globus-libtool glue package. In this way the necessary GPT package descriptions are there if someone uses gpt to verify the installation as above, and the RPM dependency generation is kept simple. Merging devel with main in this package would spoil the clear separation between development and runtime libraries and make a binary only installation depend on development packages in the distribution and drag in unnecessary dependencies. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review