Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=455226 --- Comment #15 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2009-03-14 04:21:39 EDT --- + rpmlint is ok php-pecl-runkit.i386: I: checking php-pecl-runkit.src: I: checking php-pecl-runkit-debuginfo.i386: I: checking 3 packages and 1 specfiles checked; 0 errors, 0 warnings. + package name + spec file name + package meet the PHP Guidelines (except runkit.xml/php-pecl-runkit.xml) + License ok : PHP + License is upstream + spec in english (+ru +pl) and legible + license file in sources is not provided + sources match the upstream sources from CVS 20090215 + Source URL : CVS snapshot with comment + build on F10.x86_64 (php 5.3) + BuildRequires ok + no locale + no .so + own all directories that it creates + no duplicate file - %defattr (644,root,root,755) + %clean section + use macros consistently + contain code + small documentation + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 + build in mock (F10 i386 / php 5.2.9) + build in koji (rawhide / php 5.2.9) - test suite doesn't run - scriptlets register/unregister ok but not silent + Final Requires ok /bin/sh /usr/bin/pecl php(api) = 20041225 php(zend-abi) = 20060613 + Final Provides ok php-pecl(runkit) = 0.9 Don't understand why you switch back to runkit.xml (rather then php-pecl-runkit.xml). Not a must (new Guidelines approved by FPC but not yet inline) http://fedoraproject.org/wiki/PackagingDrafts/PHP I can't run the test suite, probably because I use PHP 5.3, what are the result under PHP 5.2 ? MUST : make the %post/postun scriptlet silent use the default %defattr(-,root,root,-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review