Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467418 --- Comment #5 from Michel Alexandre Salim <michel.sylvan@xxxxxxxxx> 2009-03-13 17:15:56 EDT --- configure is testing for GLIB2: checking for GLIB2... no but this is probably a (minor) configure.in bug. It looks like GLIB2 is only pulled in if building with DeviceKit support. Review: (-) rpmlint: source clean. binary: contains manpage, this should probably be removed mingw32-libvirt.noarch: W: manpage-not-gzipped /usr/i686-pc-mingw32/sys-root/mingw/share/man/man1/virsh.1 (+) package name (+) spec file name (+) package meets guidelines for inclusion (+) license meets guideline (+) license field accurate (-) license not deleted COPYING.LIB is included, but COPYING is not (+) spec language (+) spec is legible (+) source meets upstream (+) package compiles (tested on rawhide i586) (N/A) excludearch (+) build deps complete (+) %find_lang for locales (N/A) ldconfig for shared libraries (+) directory ownership (+) file listing not duplicated (+) permissions (+) %clean (+) macros consistent (+) package contains code (N/A) large docs in -doc (N/A) -doc not needed at runtime (N/A) headers in -devel (package is for development) (N/A) static libs in -static (+) .pc -> req pkgconfig (note: dir ownership provided by mingw32-filesystem) (N/A) .so in -devel (N/A) -devel req versioned base (-) package contains .la archive: %{_mingw32_libdir}/libvirt.la (N/A) desktop file packaging (+) not owning pre-owned files/dirs (+) install clears buildroot (+) filenames UTF-8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review