Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478613 Michel Alexandre Salim <michel.sylvan@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |michel.sylvan@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Michel Alexandre Salim <michel.sylvan@xxxxxxxxx> 2009-03-13 14:53:51 EDT --- Some initial comments: - If packaging Emacs modes, you might want to consider making a separate subpackage that depends on emacs. See for instance how I handle it for vala: http://cvs.fedoraproject.org/viewvc/devel/vala/vala.spec?revision=1.36 - chmod -x scripts/* should probably be done in %setup, not %build. It's not really part of the build process - There are some GCC 4.4 incompatibilities that will need to be fixed: http://koji.fedoraproject.org/koji/taskinfo?taskID=1240356 C++'s <cstr> and <string.h> functions now return a const char * if the input is const char *, and a char * if the input is char *. - You modified the .texi file, but do not BuildRequire: texinfo, so the documentation is not regenerated See F-10 build log: http://koji.fedoraproject.org/koji/taskinfo?taskID=1240369 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review