Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489614 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review+ --- Comment #6 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-03-13 14:07:12 EDT --- Well, the latter is what's already there, so I'll just go ahead. * source files match upstream. sha256sum: 273a9866a5b927315e98518ac2aeb3083effb58816815122923d3fac4ae5c29e Authen-Krb5-Admin-0.11.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: Admin.so()(64bit) perl(Authen::Krb5::Admin) = 0.11 perl-Authen-Krb5-Admin = 0.11-1.fc11 perl-Authen-Krb5-Admin(x86-64) = 0.11-1.fc11 = libcom_err.so.2()(64bit) libcrypto.so.8()(64bit) libkadm5clnt.so.5()(64bit) libkadm5clnt.so.5(kadm5clnt_5_MIT)(64bit) libkrb5.so.3()(64bit) perl >= 0:5.004 perl(:MODULE_COMPAT_5.10.0) perl(AutoLoader) perl(Carp) perl(DynaLoader) perl(Exporter) perl(strict) perl(vars) * %check is necessarily disabled. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review