Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453848 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #12 from Hans de Goede <hdegoede@xxxxxxxxxx> 2009-03-13 09:08:22 EDT --- Full review done, looks good, so I'll approve when I'm ready to sponsor you. 2 small things you could change: 1) Put %doc directly under %files 2) Put: rm -rf autom4te.cache ./bootstrap Under %prep, that is where *most* people do autofoo regeneration. Neither are blockers though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review