Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486758 Alexey Torkhov <atorkhov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |atorkhov@xxxxxxxxx Flag| |fedora-review+ --- Comment #19 from Alexey Torkhov <atorkhov@xxxxxxxxx> 2009-03-13 06:53:43 EDT --- I went forward and did the review. Here it is with few comments: + rpmlint output clean 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + The package named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license. That is providing, that it'll be changed to "CC-BY and Freely redistributable without restriction". + File, containing the text of the licenses for the package is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package matches the upstream source. Source command to export SVN is actually wrong. It should have either "-r 9" or "@9" but not combination of those. + The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. + No need to deal with locales. + The package does not designed to be relocatable. + A package owns all directories that it creates. + A package does not list a file more than once in %files listings. + Permissions on files are set properly. + Package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT. + Package consistently uses macros. + Does not contain large documentation files. + Includes only doc files in %doc. + Includes %{name}.desktop file. Properly installed with desktop-file-install. + Package does not own files or directories already owned by other packages. + At the beginning of %install, package runs rm -rf $RPM_BUILD_ROOT. + All filenames in rpm packages are valid UTF-8. + Package builds in mock. + Package functions as described. Unfortunately, upstream's make system is made in such way so it doesn't support paralleling - it compresses one file per time. Perhaps, this should be addressed upstream. This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review