Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476398 --- Comment #4 from Alex Lancaster <alexl@xxxxxxxxxxxxxxxxxxxxx> 2009-03-13 04:56:43 EDT --- (In reply to comment #3) > So, the issues are: > - use install -p > - fix the soname mess, probably install to a subdirectory of _libdir? Right, yes fix those issues and generate a new spec and I'll finish off the review. Also ping upstream about the license if you get a chance (not necessary for finishing the review). > (I'm aware that the release cannot be reset to 1 when a new patch comes along, > a number of packages I have use pre-release or otherwise weird versioning.) OK, that's fine, so long as you are aware of that and ensure that upgrade paths are always maintained. (Also please make a note of this situation in the spec file near the version number so that other provenpackager maintainers who may need to fix the package from time to time). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review