Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476350 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-03-12 18:29:25 EDT --- rpmlint says: python-networkx.noarch: E: explicit-lib-dependency python-matplotlib which is bogus. I can't find where the license is limited to LGPLv2 only. Nothing seems to mention a version, which would imply LGPLv2+. Or did I miss something? You also need to include the doc/GNU_LGPL.txt file as documentation. I wonder if it isn't a bit broken that rpm byte-compiles the examples. I'm not sure if there's a reasonable way to get it to stop doing so. There is some sort of included test suite. I don't know quite enough about python to know how to run it, though there are some instructions in networks/tests/README. You will quite a few additional build deps, of course. * source files match upstream. sha256sum: 8b65557c6048a2bc4d5fb0fe539139d3656d9c86367c89297ad40e12e90766ad networkx-0.99.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. X license field does not seem to match the actual license. * license is open source-compatible. X license text not included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane: python-networkx = 0.99-1.fc11 = PyYAML ipython numpy pydot python(abi) = 2.6 python-matplotlib scipy X %check is not present, but there's a runnable test suite. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review