Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfsdump https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201779 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-08-18 17:41 EST ------- OK, I'll go ahead and review this. The links at the top are the only ones I could find for the package; is that actually the current version? First off, it doesn't build due to a lack of ncurses-devel. Once I add that it does build. Here's what rpmlint says: W: xfsdump symlink-should-be-relative /usr/sbin/xfsrestore /sbin/xfsrestore W: xfsdump symlink-should-be-relative /usr/sbin/xfsdump /sbin/xfsdump Indeed, these should be relative symlinks. Plus there are tons of these in the debuginfo package: W: xfsdump-debuginfo dangling-relative-symlink /usr/src/debug/xfsdump-2.2.38/dump/inv_stobj.c ../inventory/inv_stobj.c It seems that rpmbuild doesn't include the "common" directory in the package for whatever reason. I don't know how to convince it to do so. I guess that if it were a big deal you could flatten the links. Unfortunately I don't know whether it's a big deal or not so I'll have to ask around. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review