Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488010 --- Comment #33 from Jens Petersen <petersen@xxxxxxxxxx> 2009-03-12 04:35:21 EDT --- Here is the review: +:ok, =:needs attention, -:needs fixing, NA: not applicable MUST Items: [+] MUST: rpmlint output [+] MUST: Package Naming Guidelines [+] MUST: spec file name must match base package %{name} [+] MUST: Packaging Guidelines. [+] MUST: Licensing Guidelines [+] MUST: License field in the package spec file must match actual license. [+] MUST: include license files in %doc if available in source [+] MUST: The spec file must be written in American English and be legible. [+] MUST: source md5sum matches upstream release 21b4c23cd7c700330d7006d8c38f3b2e ibus-table-cangjie-1.1.0.20090309.tar.gz [+] MUST: must successfully compile and build into binary rpms on one main arch [+] MUST: All build dependencies must be listed in BuildRequires [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A package must not contain any duplicate files in the %files listing. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. [+] MUST: The package must contain code, or permissable content. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: All filenames in rpm packages must be valid UTF-8. SHOULD Items: [?] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. Any Chinese translation available? [+] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: The reviewer should test that the package functions as described. However words/minute feature should be disabled. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. Apart from comment 31, I think the package looks ok now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review