Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: netlabel_tools https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203190 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-08-18 16:39 EST ------- I don't see you in owners.list; do you require sponsorship? Is there an upstream location for the source? You should provide a URL to the packages main page and make Source0: a full URL so that reviewers can compare against the upstream source. (I'm guessing that http://free.linux.hp.com/~pmoore/projects/linux_cipso/ is the upstream.) You don't use the %{?dist} tag, which is not strictly required but is recommended because it greatly simplifies maintainance across multiple releases. http://fedoraproject.org/wiki/Packaging/DistTag Your build root is not the recommended one: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) No %{?_smp_mflags} on your make line. If the package won't build in parallel, please add a comment indicating that. Note that this is not a complete review; I'm just commenting on a few things I noticed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review