Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489294 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #7 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-03-12 03:09:10 EDT --- Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1231385 + rpmlint output for SRPM and for RPM is silent. + source files match upstream url 01b8a19489601850192476a06393cf47 icc_examin-0.46.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + update-mime-database,update-desktop-database scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed correctly. + GUI app. + Package icc_examin-0.46-1.fc11.i586 => Provides: mimehandler(application/x-cgats) mimehandler(application/x-icc) mimehandler(model/vrml) mimehandler(x-world/x-vrml) Requires: libGL.so.1 libGLU.so.1 libX11.so.6 libXext.so.6 libXinerama.so.1 libXpm.so.4 libXxf86vm.so.1 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdl.so.2 libelektra.so.3 libfltk.so.1.1 libfltk_gl.so.1.1 libfltk_images.so.1.1 libfreetype.so.6 libftgl.so.0 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libjpeg.so.62 liblcms.so.1 libm.so.6 libm.so.6(GLIBC_2.0) libm.so.6(GLIBC_2.1) liboyranos.so.0.1.9 libpng12.so.0 libpthread.so.0 libpthread.so.0(GLIBC_2.0) libpthread.so.0(GLIBC_2.1) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) libstdc++.so.6(GLIBCXX_3.4.11) libstdc++.so.6(GLIBCXX_3.4.9) libxml2.so.2 libz.so.1 rtld(GNU_HASH) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review