Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476622 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review? --- Comment #11 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-03-11 17:48:41 EDT --- forge.ocamlcore.org's certificate is invalid (or at least self-signed); I recommend using http links so tools like spectool will work. There's no separate %check section, but I think the tests are running during %build. However, I'm not really sure how to read the output. Are they being run, or just built? Any hints for me? It looks like 0.8.4 is out. I doubt it will make much difference packaging wise so I'll go ahead and review this and you can update if you like. The license file is duplicated; current guidelines forbid this. * source files match upstream. sha256sum: 87b7f3f782b448e13924630a29511eb064c6e1bb613eabcbb733d7c4c445dc0c pa_do-0.8.3.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. X latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: ocaml-pa-do-0.8.3-2.fc11.x86_64.rpm ocaml(Pa_do) = 971be223d707310f2a458c64d3419d67 ocaml(Pa_do_nums) = 091e99b411e6b077e65bf341508e57f2 ocaml(Pa_do_top) = 5ec8bd77ec745470937cd44f0e4c37e2 ocaml(Pa_infix) = 01c10d0e5d9d4982c560905f9590445e ocaml-pa-do = 0.8.3-2.fc11 ocaml-pa-do(x86-64) = 0.8.3-2.fc11 = ocaml(Arg) = b6513be035dc9c8a458c189cd8841700 ocaml(Array) = 9c9fa5f11e2d6992c427dde4d1168489 ocaml(Big_int) = b094bddd70d11f4b8592f3957a8b3d9f ocaml(Buffer) = 23af67395823b652b807c4ae0b581211 ocaml(CamlinternalLazy) = ed280fb9736e9200aa47db73c5ff077f ocaml(CamlinternalOO) = f83f268cd1a00c37180b9b1fb9306031 ocaml(Camlp4) = bb930f7c2bed5d057c794fe07dc8596a ocaml(Camlp4_config) = 80b5d58834366711574a5ec4dfb123fd ocaml(Camlp4_import) = 901773aae9273de4d3a05d3a93dde334 ocaml(Char) = 3da72249626c7db769beafc97036cb4f ocaml(Consistbl) = caff227b73e80a299bc9064d8932a731 ocaml(Digest) = 310db9d3dd12d84178f002a532644c84 ocaml(Env) = 85c160706e01672db948b045d51d0663 ocaml(Filename) = 7cd172f02b7ee9b8d7bda3bb92144951 ocaml(Format) = b7ba3152a5eec5609d6ab86e6c51eebb ocaml(Hashtbl) = ee2a3220e38a4350c5bc131ce9f3f6ce ocaml(Ident) = d2f1896a13d2b6ab5a7f039f2e1e4baf ocaml(Int32) = b2545c419b6b6a173cac4c0a3e7e0277 ocaml(Int64) = d501d6e89fdce41c79f274fb464995d5 ocaml(Lazy) = 4c7ed568fa7b5f73a2aa02eeb0e5e12b ocaml(Lexing) = 4d17267334f1a6c75730dc3fae21fb9b ocaml(List) = a0e2e49d266ff302f8667651a43f71ba ocaml(Location) = 0d236ae3a37e3f5f553fe29e883ac46d ocaml(Longident) = af7a4daa7675e00536bcf34c30f1ef8e ocaml(Map) = d6ea0139afe59a16df7b23d35e571de7 ocaml(Nat) = 3ba7c2bfbc706aa841271c572dbb55de ocaml(Nativeint) = 7233ce5207a538fea4f0c61ed411ea2c ocaml(Num) = a130968f082cd5c0b9fd83b97c9603c1 ocaml(Obj) = c827f726ce05da709cf7de58fc15e324 ocaml(Parsing) = 29c3f123280f8e6e639cfb025b3c9a3f ocaml(Path) = 3f80ef0865cd9994e2dcb1444d86c8b9 ocaml(Pervasives) = 88cb1505c8bdf9a4dcd2cdf3452732b4 ocaml(Primitive) = ffb9c662271efdee731a555268b835a9 ocaml(Printf) = 807ecd3a1538992580464c03462c9964 ocaml(Queue) = 56b5e04dcda600ae0cdf49a37f17fcd9 ocaml(Random) = 462fc826fd1ae9df8d15e3cb798cba9d ocaml(Ratio) = 5ee67f3f53c78b1d40c5da48028935f3 ocaml(Set) = c4be5d24d30c129dd60d2739e54db7dd ocaml(Stream) = 91a43ea7fb16bf36f3f10c0dc7d08a0e ocaml(String) = ecc403546c1c50056801131811c39017 ocaml(Sys) = 21bf525b2b3f3a46a54b96163adfe387 ocaml(Topdirs) = 259bd544fdba007c4f0fb2efdbf8e3e2 ocaml(Toploop) = 85ab2f8a53c5adc2ef86abcfd6f2aa92 ocaml(Types) = 51884d3e170a51d2c53e50c054df93c5 ocaml(Warnings) = f8edde181ba3c5ccbccdbdcf0e922d3a ocaml(runtime) = 3.11.0 ocaml-pa-do-devel-0.8.3-2.fc11.x86_64.rpm ocaml-pa-do-devel = 0.8.3-2.fc11 ocaml-pa-do-devel(x86-64) = 0.8.3-2.fc11 = ocaml-pa-do = 0.8.3-2.fc11 ? Not sure about the test suite. * owns the directories it creates. * doesn't own any directories it shouldn't. X LICENSE file is duplicated. * file permissions are appropriate. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * .cma, .cmi, .so, .so.owner, META files in the main package. * .a, .cmxa, .cmx and .mli files are in the -devel subpackage. * .o and .ml files not included (a syntax extension, so .cmo files are OK) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review