Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481695 Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jochen@xxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jochen@xxxxxxxxxxxxxxx Flag| |fedora-review?, needinfo? --- Comment #3 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2009-03-10 13:43:07 EDT --- Good: + Base name of SPEC files fit with package name + Package name fits with packaging guidelines + Package contains valid License tag * License tag sax GPLv2 and BSD as valid OSS licenses * License are ok for source (GPLv2) and images (BSD) + Package contains verbatin copies of the different licenses. * URL tag shows to valid project homepage + Could downloaded tar ball from upstream via spectool -g + Packaged tarball matches with upstream release (md5sum: ffebd2e9ddec6a73611f59f5699e92c6) + Package contains no patches + Package contrains no subpackages + Declared BuildRequires seems to be ok. + Local build works fine + Scratch build on koji works fine + Local install works fine + Local unstnstall works fine + Package will been built for noarch * Rpmlint is quite on source package + Rpmlint is quite on binary package + Consistently usage of rpm macros + Package contains proper BuildRoot definition + Package contains %clean stanza + BuildRoot will been deleted at start of %install and %clean + Files has proper permissions + %file stanza has no duplicates + All files are own by the package + Package contains no files own by other packages. + Package contains proper %changelog Bad: - egg-info directory should be deleted -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review