Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489293 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-03-10 06:01:42 EDT --- (In reply to comment #3) > You don't have kdelibs-devel installed as it's BR. > > F10 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1234342 yes you are correct. something goes wrong when I tried to install kdelibs-devel and I assumed I have it installed. mirrors are not in sync. Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1231229 + rpmlint output for SRPM and for RPM. kvkbd.i586: W: dangling-symlink /usr/share/doc/HTML/en/kvkbd/common /usr/share/doc/HTML/en/common ==> Can be ignored. + source files match upstream url 342e8e7fcfc54d978615b1c2d019cbe5 94374-kvkbd-0.6.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed correctly. + GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review