Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489130 --- Comment #5 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-03-09 22:21:05 EDT --- (In reply to comment #4) > Hi Orcan, > > I've reviewed your request. Please consider this as an inofficial review since > I'm new in the packager's group. I hope I could help anyway. ;-) > Chris, welcome to Fedora and thanks for the unofficial review. It will certainly speed things up. > > * package compilable: BAD > - compiles in F10, i386 > - fails at least for the 64 bit archs > - https://koji.fedoraproject.org/koji/taskinfo?taskID=1233610 > - https://koji.fedoraproject.org/koji/taskinfo?taskID=1233605 > - https://koji.fedoraproject.org/koji/taskinfo?taskID=1233600 > - problem should be either fixed or the architectures should be excluded in the > spec file > I didn't know mono was unavailable in ppc64, so I put that in ExcludeArch. I also filed a bug for this as required by the guidelines https://bugzilla.redhat.com/show_bug.cgi?id=489435 The x86_64 build was failed because a flawed version of mono is tagged in buildroot. I filed a ticket to releng https://fedorahosted.org/rel-eng/ticket/1322 and let the mono packager know about the problem https://bugzilla.redhat.com/show_bug.cgi?id=489129#c4 Unfortunately, it won't be available to build mono on koji on F-10 until the flawed version of mono is untagged. Meanwhile, the rawhide version is built in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1233875 > > * devel packages containing pkgconfig files must require pkgconfig: BAD > I missed this one. Fixed in this new release. > > * GTK+ icon cache: seems to be ok, however it differs sligthly from the example > in http://fedoraproject.org/wiki/Packaging/ScriptletSnippets > That page is a little outdated. There is a new guideline for icon cache that was recently approved by FESCo: https://www.redhat.com/archives/fedora-devel-list/2009-February/msg01604.html https://fedoraproject.org/wiki/PackagingDrafts/Icon_Cache > Regards, > Christian Thanks again for your comments and have fun in Fedora. Updated files: Spec URL: http://oget.fedorapeople.org/review/gnome-guitar.spec SRPM URL: http://oget.fedorapeople.org/review/gnome-guitar-0.8.1-2.fc10.src.rpm Changelog: 0.8.1-2 - Add ExcludeArch:ppc64 since mono is not available in this architecture. - devel subpackage requires pkgconfig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review