Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486757 --- Comment #8 from David A. Wheeler <dwheeler@xxxxxxxxxxxx> 2009-03-09 12:39:26 EDT --- I've resolved all the comments above, and I think it's ready to go: * The patches had already been submitted; the .spec file now includes the link * gcc flags - exported before ./configure, removed -fomit-frame-pointer * Let rpmlint whine. * make VERBOSE=1 * the examples/ should be simply packaged as %doc too. * No longer use "--help" as a test; there are better tests anyway. * Rebuilt the prebuilt jars * Fixed sed to remove -gstabs+ * I didn't add _additional_ tests, but I fully automated checking the test results for the tests I had. Builds on Fedora 10 and Fedora 11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1231458 http://koji.fedoraproject.org/koji/taskinfo?taskID=1231988 rpmlint emits one complaint, which is spurious: divine-mc.spec:114: W: configure-without-libdir-spec 0 packages and 1 specfiles checked; 0 errors, 1 warnings. As noted in the .spec file, this is because the "./configure" program isn't GNU configure (it's from cmake), so there is no libdir option to invoke. Therefore, ignore the rpmlint warning from this line. I think it's ready to go! Would you approve this, so we can get this into CVS today (and meet the F11 deadline)? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review