Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=273701 Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rpm@xxxxxxxxxxxxxx --- Comment #67 from Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> 2009-03-08 15:46:16 EDT --- Some small issues with the spec file: Packager: Lightspeed Technologies Vendor: Lightspeed Technologies These fields will be overwritten by Fedora build system, hence they can be dropped. For readability's sake I'd ask you to reformat BuildRequires, i.e. put each in its own line and sort them alphabetically. This will also make diffs smaller if there are any updates to them. Additionally, I'm pretty certain that some of the BuildRequires are redundant. I'll try to provide a list later. The -devel subpackage is missing Requires: pkgconfig, which is mandatory for all packages that ship .pc files. %{_datadir}/applications/* For just one file you could simply spell it out: %{_datadir}/applications/application-browser.desktop %{_datadir}/gnome-main-menu/* %{_includedir}/slab/* makes %{_datadir}/gnome-main-menu and %{_includedir}/slab directories unowned, so just drop the /*. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review