Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480279 --- Comment #14 from Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx> 2009-03-08 14:59:19 EDT --- (In reply to comment #13) > > It should be marked as %config(noreplace) - that is what warning says. No it shouldn't, as gconf files are no config files and not supposed to be edited by users. Just ignore the warning. Some more comments: - please add a blank line between new changelog entries for legibility - devel package needs "Requires: pkgconfig" because it puts files into %{_libdir}/pkgconfig which is owned by pkgconfig - the files section of the devel package could be stripped down with wildcards: %{_includedir}/libgnomenu/*.h instead of listing all files one by one - %{_includedir}/libgnomenu/ is unowned and will be left behind after uninstalling the devel package. So in addition to the above you need %dir %{_includedir}/libgnomenu/ - %{_libdir}/libgnomenu.so belongs into the devel package and not into common, see http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - %{_libdir}/gtk-2.0/modules/libglobalmenu-gnome.so is an exception from this rule, so it's ok - requirements for subpackages should be fuly versioned, see http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage so the gnome-panel package needs: Requires: gnome-globalmenu-common = %{version}-%{release} - Requires: gtk2 is not necessary as rpm will pick up dependencies on libs automatically and other packages (xfce4-panel/gnome-panel) already requires it. - Requires: gnome-menus is not necessary ether, because it is already required be gnome-panel - You are running ldconfig in %post and %postun of the common package, so it also needs Requires(post): ldconfig Requires(postun): ldconfig - Requires(pre): GConf2 Requires(post): GConf2 Requires(preun): GConf2 also belong to the common package and not to the empty base package - Does it really make sense to package the gtkmodule separately? - I wonder it the gnome-globalmenu-gnome-panel should be named gnome-applet-globalmenu instead, because this would follow the naming guidelines for panel applets. - Same for gnome-globalmenu-xfce4-panel: Call it xfce4-globalmenu-plugin instead? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review