Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483726 --- Comment #4 from Dan Horák <dan@xxxxxxxx> 2009-03-08 12:17:08 EDT --- (In reply to comment #1) > Builds fine and rpmlint is silent. > > I won't ask you about the upstream status of the patch since you seem to be > upstream. No, I am only providing part of my web space to Douglas Gilbert who is the upstream. But the patch was already accepted by him. > Please use a proper build root. At minimum it needs to reference %{release}. Oh, that's my omission when I was adapting the upstream spec file. > Really, that's the only issue I see, and I'm happy to just let you fix it up > when you import the package. Yes, I will update it before importing. > The package review process needs reviewers! If you haven't done any package > reviews recently, please consider doing one. Well, I have fulfilled my quota for this week with 5 finished reviews :-) Thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review