Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467408 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |erik-fedora@xxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |erik-fedora@xxxxxxxxxxxxxxx Flag| |fedora-review? Bug 467408 depends on bug 467401, which changed state. Bug 467401 Summary: Review Request: mingw32-libjpeg - MinGW Windows Libjpeg library https://bugzilla.redhat.com/show_bug.cgi?id=467401 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED --- Comment #3 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> 2009-03-08 12:11:35 EDT --- This review is done for the -7 release which is on the annexia.org webserver. - The %defattr line must be %defattr(-,root,root,-) - The purpose of the patches (or upstream bugreport) should be mentioned in the .spec file - The patch 'jasper-1.701.0-GL.patch' has no effect as OpenGL support is disabled using a ./configure flag - According to http://www.nondot.org/sabre/Mirrored/libtool-2.1a/libtool_5.html, the AM_DISABLE_SHARED macro is used for setting the default behaviour for building shared libraries. "The user may still override this default by specifying `--enable-shared'". So it should be sufficient to drop the 'jasper-1.900.1-mingw32.patch' patch and use '--enable shared' as ./configure flag. - The patch 'jasper-1.900.1-mingw32.patch' can be simplified by only adjusting the Makefile.in. This prevents having to use autoconf while still archieving the same effect -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review