Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478852 Alexey Torkhov <atorkhov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #11 from Alexey Torkhov <atorkhov@xxxxxxxxx> 2009-03-07 13:34:52 EDT --- - rpmlint output: lpairs.src:77: W: macro-in-%changelog pre lpairs.src: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 1) lpairs.src: W: non-coherent-filename lpairs-1.0.4-5.src.rpm lpairs-1.0.4-5.fc8.src.rpm 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Please clean up mixed spaces and tabs; and macros in changelog. + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license. + File, containing the text of the licenses for the package is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package matches the upstream source, as provided in the spec URL. 5eb00da9f7fc15dc5ce840c312e76cfa lpairs-1.0.4.tar.gz 5eb00da9f7fc15dc5ce840c312e76cfa lpairs-1.0.4.tar.gz.orig + The package successfully compiles and builds into binary rpms on at least one primary architecture (x86_64). + All build dependencies are listed in BuildRequires. + The spec file handles locales properly. + Does not contain shared libraries. + The package does not designed to be relocatable. + A package owns all directories that it creates. + A package does not contain any duplicate files in the %files listing. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot}. + The package consistently uses macros. + The package contains code, or permissible content. + Does not contain large documentation files. + Includes only doc files in %doc. + No headers. + No static libraries. + The package does not contain pkgconfig(.pc) files. + The package does not contain library files with a suffix (e.g. libfoo.so.1.1). + No devel packages. + The package does not contain any .la libtool archives. + Includes %{name}.desktop file. Properly installed with desktop-file-install. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot}. + All filenames in the package are valid UTF-8. SHOULD: Source package does not include CC-BY-SA license text and license for sounds as a separate file from upstream, should query upstream to include it. This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review