Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483381 --- Comment #2 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-03-07 10:34:44 EDT --- (In reply to comment #1) > - Licensing issues should be cleaned up: > > a) There is no indication of GPL version in code or docs at all. (There is no > indication of license at all, but that's another question). > As such, License tag should be without version - "GPL+". > > b) Maps data was taken from pmetro.nm.ru. And it have the following license in > Russian language (http://pmetro.nm.ru/License.html): > Данные, использованные в программе, свободны для некоммерческого использования, > а также для GPL проектов. > > My translation: > Data used in program is free for non-commercial use and also for GPL projects. > > That is not very clear situation. Could you query license for data upstream? > In particular they should tell what are terms for: > * use > * modification > * redistribution The license files says GPLv2. Fixed > - Source url is wrong. Instead of > http://downloads.sourceforge.net/metromap/metromap-0.1.2.tar.bz2 > it should be: > http://downloads.sourceforge.net/metro-map/metromap-0.1.2.tar.bz2 fixed > - pygtk2-devel is not required in BuildRequires. It should have pygtk2 in > Requires instead. fixed Updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/metromap.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/metromap-0.1.2-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review