Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480103 --- Comment #8 from Michael Schwendt <bugs.michael@xxxxxxx> 2009-03-07 05:08:32 EDT --- > -License: GPLv2+ > +License: GPLv2 Confirmed. The source files explicitly say "LICENSE: GPL Version 2". > +%package devel https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > +Group: Applications/Internet That sounds wrong for the bnIRC-devel package. More likely the group is "Development/Libraries". Even if the package contained just a plugin API, there would not be a more accurate RPM Group. > -%post -p /sbin/ldconfig > - > -%postun -p /sbin/ldconfig Deleting them is not right. The previous .spec file was correct. Put them back. > -%{_datadir}/%{name}-%{version} > +%{_datadir}/%{name}-%{version}/* With this change, the directory is not included. Please revert. https://fedoraproject.org/wiki/Packaging/UnownedDirectories > +%files devel > +%defattr(-,root,root,-) > +%{_prefix}/src/* Don't include %_prefix/src. These are included in the automatically generated -debuginfo package. If that doesn't work for you, install the "redhat-rpm-config". > +%{_libdir}/bnIRC/* These are the application's plugins. They belong into the main package. > +%{_libdir}/libbnirc.a > +%{_libdir}/libbnirc.la These are not needed and must not be included. You can %exclude it or remove it in the %install section. http://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries > +%{_libdir}/libbnirc.so This is the softlink that really belongs into the -devel package. It is needed when compiling/linking with -lbnirc > +%{_libdir}/libbnirc.so.0 > +%{_libdir}/libbnirc.so.0.0.0 These two belong into the main application package. Your %changelog doesn't comment on several of the spec changes between release 3 and 5. It is good practise to document and explain non-trivial modifications. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review