Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479874 Richard W.M. Jones <rjones@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(itamar@ispbrasil. | |com.br) --- Comment #6 from Richard W.M. Jones <rjones@xxxxxxxxxx> 2009-03-06 15:18:33 EDT --- (In reply to comment #4) > I started trying to do this review, but I kept tripping over things: > > - Package uses %{_mingw32_libdir}/*, see: > http://fedoraproject.org/wiki/Packaging/MinGW#Do_not_use_.25.7B_mingw32_bindir.7D.2F.2A_or_.25.7B_mingw32_libdir.7D.2F.2A_in_.25files_section Itamar [packager], I'd prefer if the libraries were listed explicitly. We have had problems with libtool "disappearing" libraries, and by listing them explicitly we catch this. > - Spec is missing correct BuildRequires (see Comment #3) > - Package contains static libraries: > /usr/i686-pc-mingw32/sys-root/mingw/lib/libecpg.a > /usr/i686-pc-mingw32/sys-root/mingw/lib/libecpg_compat.a > /usr/i686-pc-mingw32/sys-root/mingw/lib/libpgport.a > /usr/i686-pc-mingw32/sys-root/mingw/lib/libpgtypes.a > /usr/i686-pc-mingw32/sys-root/mingw/lib/libpostgres.a > /usr/i686-pc-mingw32/sys-root/mingw/lib/libpq.a > > See: http://fedoraproject.org/wiki/Packaging/MinGW#Static_libraries Itamar, are we building this library statically? We certainly shouldn't be - we should build DLLs always. If you need static libraries, then they should go in a separate -static subpackage. > - Not in sync with rawhide (8.3.6 vs 8.3.5). > - Normal postgresql is carrying six patches not found here: > Patch1: rpm-pgsql.patch > Patch2: postgresql-ac-version.patch > Patch3: postgresql-logging.patch > Patch4: postgresql-test.patch > Patch5: pgtcl-no-rpath.patch > Patch6: postgresql-perl-rpath.patch > - Built with an entirely different set of configure options Itamar, all of these should be fixed. We should keep the package as close to the native Fedora package as possible, mainly because it reduces the chance that we are susceptible to different bugs or security errata than the native package. So we benefit from the native package's testing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review