Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483696 Michael Schwendt <bugs.michael@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |bugs.michael@xxxxxxx Flag| |fedora-review? --- Comment #2 from Michael Schwendt <bugs.michael@xxxxxxx> 2009-03-06 14:43:18 EDT --- * Noticed you're [involved] upstream. * Hint: Run rpmlint not just on the src.rpm, but also on the built rpms. > Requires: glib2, libsoup, avahi-glib Should really be dropped in favour of the automatic SONAME dependencies. However: You don't add the proper LDFLAGS to link with these libraries. libdmapsharing-1.9.so.1.0.9 contains undefined symbols! That's why you don't get rpmbuild's automatic SONAME deps. > %post > /sbin/ldconfig > > %postun > /sbin/ldconfig Prefer %post -p /sbin/ldconfig %postun -p /sbin/ldconfig to run this command directly instead of via /bin/sh. * -devel pkg ought to "Requires: pkgconfig", because it stores a file in %_libdir/pkgconfig/ and because libdmapsharing API users will likely evaluate the pkg-config --cflags/--libs values for this library. * %doc file "INSTALL" is irrelevant to RPM package users * The installed pkg-config file contains a hardcoded /lib in libdir. This breaks on 64-bit archs. Use @libdir@ in the .pc.in template file. * The major library version as part of the SONAME is intentional? (libdmapsharing-1.9.so.1.0.9) * What "license issue" does the TODO file refer to? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review