Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487527 Marcela Maslanova <mmaslano@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mmaslano@xxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Marcela Maslanova <mmaslano@xxxxxxxxxx> 2009-03-05 08:51:51 EDT --- OK Rpmlint must be run on every package. OK The package must be named according to the Package Naming Guidelines. OK The spec file name must match the base package %{name}. OK The package must meet the Packaging Guidelines. OK The package must be licensed with a Fedora approved license. OK The License field in the package spec file must match the actual license. OK If (and only if) the source package includes the text of the license(s) in its own file. OK The spec file must be written in American English. OK The spec file for the package MUST be legible. OK f4fbb3465bdc0d0ac27bdd2972f7f469 The sources used to build the package must match the upstream source. OK The package MUST successfully compile. OK Correct BuildRequires. OK Proper use of %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. OK Shared library files (not just symlinks) must call ldconfig in %post and %postun. OK Relocatable package must state this fact in the request for review. OK A package must own all directories that it creates. OK A package must not contain any duplicate files in the %files listing. ? Permissions on files must be set properly. OK Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK Each package must consistently use macros. OK The package must contain code, or permissable content. OK Large documentation files must go in a -doc subpackage. OK If a package includes something as %doc, it must not affect the runtime of the application. OK Header files must be in a -devel package. OK Static libraries must be in a -static package. OK Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK Library files with a suffix (e.g. libfoo.so.1.1) and files that end in .so (without suffix) must go in -devel. OK In the vast majority of cases, devel packages must require the base package. OK Packages must NOT contain any .la libtool archives. OK Packages containing GUI applications must include a %{name}.desktop file. OK At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). Usually instead of 755 in %defattr(-, root, root, 0755) is used simply -. rpmlint has true. The scripts which are installed into /usr/share meant to be examples. That means they shouldn't be executable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review